From 3a065b268c5ee717b34a9ce8a086fd1d414a660a Mon Sep 17 00:00:00 2001 From: Nutomic Date: Fri, 3 Jan 2025 18:41:20 +0000 Subject: [PATCH 1/4] Upgrade deps (#133) * Upgrade deps * fmt * fix --- Cargo.toml | 62 +++++++++++++------------- examples/local_federation/axum/http.rs | 4 +- src/actix_web/inbox.rs | 8 ++-- src/axum/inbox.rs | 2 - src/axum/middleware.rs | 3 +- src/error.rs | 9 +++- src/lib.rs | 4 +- 7 files changed, 47 insertions(+), 45 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 5ac2d79..e08c794 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -32,70 +32,70 @@ redundant_closure_for_method_calls = "deny" unwrap_used = "deny" [dependencies] -chrono = { version = "0.4.38", features = ["clock"], default-features = false } -serde = { version = "1.0.204", features = ["derive"] } -async-trait = "0.1.81" -url = { version = "2.5.2", features = ["serde"] } -serde_json = { version = "1.0.120", features = ["preserve_order"] } -reqwest = { version = "0.12.5", default-features = false, features = [ +chrono = { version = "0.4.39", features = ["clock"], default-features = false } +serde = { version = "1.0.217", features = ["derive"] } +async-trait = "0.1.84" +url = { version = "2.5.4", features = ["serde"] } +serde_json = { version = "1.0.134", features = ["preserve_order"] } +reqwest = { version = "0.12.12", default-features = false, features = [ "json", "stream", "rustls-tls", ] } -reqwest-middleware = "0.3.2" -tracing = "0.1.40" +reqwest-middleware = "0.4.0" +tracing = "0.1.41" base64 = "0.22.1" rand = "0.8.5" -rsa = "0.9.6" -once_cell = "1.19.0" -http = "1.1.0" +rsa = "0.9.7" +once_cell = "1.20.2" +http = "1.2.0" sha2 = { version = "0.10.8", features = ["oid"] } -thiserror = "1.0.62" -derive_builder = "0.20.0" -itertools = "0.13.0" +thiserror = "2.0.9" +derive_builder = "0.20.2" +itertools = "0.14.0" dyn-clone = "1.0.17" enum_delegate = "0.2.0" httpdate = "1.0.3" -http-signature-normalization-reqwest = { version = "0.12.0", default-features = false, features = [ +http-signature-normalization-reqwest = { version = "0.13.0", default-features = false, features = [ "sha-2", "middleware", "default-spawner", ] } http-signature-normalization = "0.7.0" -bytes = "1.6.1" -futures-core = { version = "0.3.30", default-features = false } -pin-project-lite = "0.2.14" +bytes = "1.9.0" +futures-core = { version = "0.3.31", default-features = false } +pin-project-lite = "0.2.15" activitystreams-kinds = "0.3.0" -regex = { version = "1.10.5", default-features = false, features = [ +regex = { version = "1.11.1", default-features = false, features = [ "std", "unicode", ] } -tokio = { version = "1.38.0", features = [ +tokio = { version = "1.42.0", features = [ "sync", "rt", "rt-multi-thread", "time", ] } -diesel = { version = "2.2.1", features = [ +diesel = { version = "2.2.6", features = [ "postgres", ], default-features = false, optional = true } -futures = "0.3.30" -moka = { version = "0.12.8", features = ["future"] } +futures = "0.3.31" +moka = { version = "0.12.9", features = ["future"] } # Actix-web -actix-web = { version = "4.8.0", default-features = false, optional = true } +actix-web = { version = "4.9.0", default-features = false, optional = true } http02 = { package = "http", version = "0.2.12", optional = true } # Axum -axum = { version = "0.7.5", features = ["json"], default-features = false, optional = true } -tower = { version = "0.4.13", optional = true } +axum = { version = "0.8.1", features = ["json"], default-features = false, optional = true } +tower = { version = "0.5.2", optional = true } [dev-dependencies] -anyhow = "1.0.86" -axum = { version = "0.7.5", features = ["macros"] } -axum-extra = { version = "0.9.3", features = ["typed-header"] } -env_logger = "0.11.3" -tokio = { version = "1.38.0", features = ["full"] } +anyhow = "1.0.95" +axum = { version = "0.8.1", features = ["macros"] } +axum-extra = { version = "0.10.0", features = ["typed-header"] } +env_logger = "0.11.6" +tokio = { version = "1.42.0", features = ["full"] } [profile.dev] strip = "symbols" diff --git a/examples/local_federation/axum/http.rs b/examples/local_federation/axum/http.rs index dd9d002..e010a73 100644 --- a/examples/local_federation/axum/http.rs +++ b/examples/local_federation/axum/http.rs @@ -30,8 +30,8 @@ pub fn listen(config: &FederationConfig) -> Result<(), Error> { info!("Listening with axum on {hostname}"); let config = config.clone(); let app = Router::new() - .route("/:user/inbox", post(http_post_user_inbox)) - .route("/:user", get(http_get_user)) + .route("/{user}/inbox", post(http_post_user_inbox)) + .route("/{user}", get(http_get_user)) .route("/.well-known/webfinger", get(webfinger)) .layer(FederationMiddleware::new(config)); diff --git a/src/actix_web/inbox.rs b/src/actix_web/inbox.rs index 9bce475..0912e72 100644 --- a/src/actix_web/inbox.rs +++ b/src/actix_web/inbox.rs @@ -122,14 +122,14 @@ mod test { let (_, _, config) = setup_receive_test().await; let actor = Url::parse("http://ds9.lemmy.ml/u/lemmy_alpha").unwrap(); - let id = "http://localhost:123/1"; + let activity_id = "http://localhost:123/1"; let activity = json!({ "actor": actor.as_str(), "to": ["https://www.w3.org/ns/activitystreams#Public"], "object": "http://ds9.lemmy.ml/post/1", "cc": ["http://enterprise.lemmy.ml/c/main"], "type": "Delete", - "id": id + "id": activity_id } ); let body: Bytes = serde_json::to_vec(&activity).unwrap().into(); @@ -144,8 +144,8 @@ mod test { .await; match res { - Err(Error::ParseReceivedActivity(_, url)) => { - assert_eq!(id, url.expect("has url").as_str()); + Err(Error::ParseReceivedActivity { err: _, id }) => { + assert_eq!(activity_id, id.expect("has url").as_str()); } _ => unreachable!(), } diff --git a/src/axum/inbox.rs b/src/axum/inbox.rs index 1767c10..84567e0 100644 --- a/src/axum/inbox.rs +++ b/src/axum/inbox.rs @@ -10,7 +10,6 @@ use crate::{ traits::{ActivityHandler, Actor, Object}, }; use axum::{ - async_trait, body::Body, extract::FromRequest, http::{Request, StatusCode}, @@ -58,7 +57,6 @@ pub struct ActivityData { body: Vec, } -#[async_trait] impl FromRequest for ActivityData where S: Send + Sync, diff --git a/src/axum/middleware.rs b/src/axum/middleware.rs index 290dc94..2f8b0e9 100644 --- a/src/axum/middleware.rs +++ b/src/axum/middleware.rs @@ -1,5 +1,5 @@ use crate::config::{Data, FederationConfig, FederationMiddleware}; -use axum::{async_trait, body::Body, extract::FromRequestParts, http::Request, response::Response}; +use axum::{body::Body, extract::FromRequestParts, http::Request, response::Response}; use http::{request::Parts, StatusCode}; use std::task::{Context, Poll}; use tower::{Layer, Service}; @@ -43,7 +43,6 @@ where } } -#[async_trait] impl FromRequestParts for Data where S: Send + Sync, diff --git a/src/error.rs b/src/error.rs index 1866e48..06c8085 100644 --- a/src/error.rs +++ b/src/error.rs @@ -44,11 +44,16 @@ pub enum Error { #[error("Failed to parse object {1} with content {2}: {0}")] ParseFetchedObject(serde_json::Error, Url, String), /// Failed to parse an activity received from another instance - #[error("Failed to parse incoming activity {}: {0}", match .1 { + #[error("Failed to parse incoming activity {}: {0}", match .id { Some(t) => format!("with id {t}"), None => String::new(), })] - ParseReceivedActivity(serde_json::Error, Option), + ParseReceivedActivity { + /// The parse error + err: serde_json::Error, + /// ID of the Activitypub object which caused this error + id: Option, + }, /// Reqwest Middleware Error #[error(transparent)] ReqwestMiddleware(#[from] reqwest_middleware::Error), diff --git a/src/lib.rs b/src/lib.rs index 0a44fc9..b7fe013 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -52,10 +52,10 @@ where ::Error: From, Datatype: Clone, { - let activity: Activity = serde_json::from_slice(body).map_err(|e| { + let activity: Activity = serde_json::from_slice(body).map_err(|err| { // Attempt to include activity id in error message let id = extract_id(body).ok(); - Error::ParseReceivedActivity(e, id) + Error::ParseReceivedActivity { err, id } })?; data.config.verify_url_and_domain(&activity).await?; let actor = ObjectId::::from(activity.actor().clone()) From 13357aea9c19830308968f60cb12771222206fc4 Mon Sep 17 00:00:00 2001 From: Felix Ableitner Date: Mon, 13 Jan 2025 10:43:07 +0100 Subject: [PATCH 2/4] remove once_cell --- Cargo.toml | 1 - src/fetch/webfinger.rs | 7 +++---- src/http_signatures.rs | 18 +++++++++--------- src/traits.rs | 7 ++++--- 4 files changed, 16 insertions(+), 17 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index e08c794..a622fd4 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -47,7 +47,6 @@ tracing = "0.1.41" base64 = "0.22.1" rand = "0.8.5" rsa = "0.9.7" -once_cell = "1.20.2" http = "1.2.0" sha2 = { version = "0.10.8", features = ["oid"] } thiserror = "2.0.9" diff --git a/src/fetch/webfinger.rs b/src/fetch/webfinger.rs index 8460245..9385455 100644 --- a/src/fetch/webfinger.rs +++ b/src/fetch/webfinger.rs @@ -7,10 +7,9 @@ use crate::{ }; use http::HeaderValue; use itertools::Itertools; -use once_cell::sync::Lazy; use regex::Regex; use serde::{Deserialize, Serialize}; -use std::{collections::HashMap, fmt::Display}; +use std::{collections::HashMap, fmt::Display, sync::LazyLock}; use tracing::debug; use url::Url; @@ -120,8 +119,8 @@ pub fn extract_webfinger_name<'i, T>(query: &'i str, data: &Data) -> Result<& where T: Clone, { - static WEBFINGER_REGEX: Lazy = - Lazy::new(|| Regex::new(r"^acct:([\p{L}0-9_\.\-]+)@(.*)$").expect("compile regex")); + static WEBFINGER_REGEX: LazyLock = + LazyLock::new(|| Regex::new(r"^acct:([\p{L}0-9_\.\-]+)@(.*)$").expect("compile regex")); // Regex to extract usernames from webfinger query. Supports different alphabets using `\p{L}`. // TODO: This should use a URL parser let captures = WEBFINGER_REGEX diff --git a/src/http_signatures.rs b/src/http_signatures.rs index aa526f9..dd92d19 100644 --- a/src/http_signatures.rs +++ b/src/http_signatures.rs @@ -19,7 +19,6 @@ use http_signature_normalization_reqwest::{ prelude::{Config, SignExt}, DefaultSpawner, }; -use once_cell::sync::Lazy; use reqwest::Request; use reqwest_middleware::RequestBuilder; use rsa::{ @@ -30,7 +29,7 @@ use rsa::{ }; use serde::Deserialize; use sha2::{Digest, Sha256}; -use std::{collections::BTreeMap, fmt::Debug, time::Duration}; +use std::{collections::BTreeMap, fmt::Debug, sync::LazyLock, time::Duration}; use tracing::debug; use url::Url; @@ -82,9 +81,9 @@ pub(crate) async fn sign_request( private_key: RsaPrivateKey, http_signature_compat: bool, ) -> Result { - static CONFIG: Lazy> = - Lazy::new(|| Config::new().set_expiration(EXPIRES_AFTER)); - static CONFIG_COMPAT: Lazy = Lazy::new(|| { + static CONFIG: LazyLock> = + LazyLock::new(|| Config::new().set_expiration(EXPIRES_AFTER)); + static CONFIG_COMPAT: LazyLock = LazyLock::new(|| { Config::new() .mastodon_compat() .set_expiration(EXPIRES_AFTER) @@ -185,7 +184,7 @@ fn verify_signature_inner( uri: &Uri, public_key: &str, ) -> Result<(), Error> { - static CONFIG: Lazy = Lazy::new(|| { + static CONFIG: LazyLock = LazyLock::new(|| { http_signature_normalization::Config::new() .set_expiration(EXPIRES_AFTER) .require_digest() @@ -287,9 +286,10 @@ pub mod test { use rsa::{pkcs1::DecodeRsaPrivateKey, pkcs8::DecodePrivateKey}; use std::str::FromStr; - static ACTOR_ID: Lazy = Lazy::new(|| Url::parse("https://example.com/u/alice").unwrap()); - static INBOX_URL: Lazy = - Lazy::new(|| Url::parse("https://example.com/u/alice/inbox").unwrap()); + static ACTOR_ID: LazyLock = + LazyLock::new(|| Url::parse("https://example.com/u/alice").unwrap()); + static INBOX_URL: LazyLock = + LazyLock::new(|| Url::parse("https://example.com/u/alice/inbox").unwrap()); #[tokio::test] async fn test_sign() { diff --git a/src/traits.rs b/src/traits.rs index 9976bda..7ca20d5 100644 --- a/src/traits.rs +++ b/src/traits.rs @@ -346,8 +346,8 @@ pub mod tests { protocol::verification::verify_domains_match, }; use activitystreams_kinds::{activity::FollowType, actor::PersonType}; - use once_cell::sync::Lazy; use serde::{Deserialize, Serialize}; + use std::sync::LazyLock; #[derive(Clone)] pub struct DbConnection; @@ -389,9 +389,10 @@ pub mod tests { pub local: bool, } - pub static DB_USER_KEYPAIR: Lazy = Lazy::new(|| generate_actor_keypair().unwrap()); + pub static DB_USER_KEYPAIR: LazyLock = + LazyLock::new(|| generate_actor_keypair().unwrap()); - pub static DB_USER: Lazy = Lazy::new(|| DbUser { + pub static DB_USER: LazyLock = LazyLock::new(|| DbUser { name: String::new(), federation_id: "https://localhost/123".parse().unwrap(), inbox: "https://localhost/123/inbox".parse().unwrap(), From c43ae9d5e3137c850ab653ccf866cd34315e21b0 Mon Sep 17 00:00:00 2001 From: Felix Ableitner Date: Mon, 13 Jan 2025 10:52:23 +0100 Subject: [PATCH 3/4] upgrade rust --- .woodpecker.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.woodpecker.yml b/.woodpecker.yml index b82dd94..f1dd4a0 100644 --- a/.woodpecker.yml +++ b/.woodpecker.yml @@ -1,5 +1,5 @@ variables: - - &rust_image "rust:1.78-bullseye" + - &rust_image "rust:1.84-bullseye" steps: cargo_fmt: From ffe24b425037ede1dc864bd792c59cdcfbba4dae Mon Sep 17 00:00:00 2001 From: Felix Ableitner Date: Mon, 13 Jan 2025 11:36:27 +0100 Subject: [PATCH 4/4] fix warnings --- src/fetch/collection_id.rs | 2 +- src/fetch/object_id.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/fetch/collection_id.rs b/src/fetch/collection_id.rs index 8c796f4..6aa9881 100644 --- a/src/fetch/collection_id.rs +++ b/src/fetch/collection_id.rs @@ -104,7 +104,7 @@ where } #[cfg(feature = "diesel")] -const _IMPL_DIESEL_NEW_TYPE_FOR_COLLECTION_ID: () = { +const _: () = { use diesel::{ backend::Backend, deserialize::{FromSql, FromStaticSqlRow}, diff --git a/src/fetch/object_id.rs b/src/fetch/object_id.rs index 108dc1a..0e01bbf 100644 --- a/src/fetch/object_id.rs +++ b/src/fetch/object_id.rs @@ -272,7 +272,7 @@ where } #[cfg(feature = "diesel")] -const _IMPL_DIESEL_NEW_TYPE_FOR_OBJECT_ID: () = { +const _: () = { use diesel::{ backend::Backend, deserialize::{FromSql, FromStaticSqlRow},