From 40117bdfdcdd40620346df5168274c334968e719 Mon Sep 17 00:00:00 2001
From: Tangel <tangel@tangel.me>
Date: Mon, 16 Dec 2024 10:31:49 +0000
Subject: [PATCH] update

---
 src/activity_sending.rs |  9 +--------
 src/actix_web/mod.rs    | 30 +++++++-----------------------
 src/fetch/mod.rs        | 10 +++-------
 src/http_signatures.rs  | 10 +++-------
 4 files changed, 14 insertions(+), 45 deletions(-)

diff --git a/src/activity_sending.rs b/src/activity_sending.rs
index c801467..46c1440 100644
--- a/src/activity_sending.rs
+++ b/src/activity_sending.rs
@@ -238,9 +238,6 @@ pub(crate) fn generate_request_headers(inbox_url: &Url) -> HeaderMap {
 mod tests {
     use super::*;
     use crate::{config::FederationConfig, http_signatures::generate_actor_keypair};
-    use axum::extract::State;
-    use bytes::Bytes;
-    use http::StatusCode;
     use std::{
         sync::{atomic::AtomicUsize, Arc},
         time::Instant,
@@ -249,11 +246,7 @@ mod tests {
     use tracing::info;
 
     // This will periodically send back internal errors to test the retry
-    async fn dodgy_handler(
-        State(_state): State<Arc<AtomicUsize>>,
-        headers: http::HeaderMap,
-        body: Bytes,
-    ) -> Result<(), StatusCode> {
+    async fn dodgy_handler(headers: HeaderMap, body: Bytes) -> Result<(), StatusCode> {
         debug!("Headers:{:?}", headers);
         debug!("Body len:{}", body.len());
         Ok(())
diff --git a/src/actix_web/mod.rs b/src/actix_web/mod.rs
index 3145be3..7683d4b 100644
--- a/src/actix_web/mod.rs
+++ b/src/actix_web/mod.rs
@@ -13,7 +13,6 @@ use crate::{
 };
 use actix_web::{web::Bytes, HttpRequest};
 use serde::Deserialize;
-use std::str::FromStr;
 
 /// Checks whether the request is signed by an actor of type A, and returns
 /// the actor in question if a valid signature is found.
@@ -27,29 +26,14 @@ where
     <A as Object>::Error: From<Error>,
     for<'de2> <A as Object>::Kind: Deserialize<'de2>,
 {
-    let header_value = request
+    let digest_header = request
         .headers()
         .get("Digest")
-        .map(|v| reqwest::header::HeaderValue::from_str(v.to_str().unwrap_or_default()))
-        .and_then(std::result::Result::ok);
-    verify_body_hash(header_value.as_ref(), &body.unwrap_or_default())?;
+        .map(http_compat::header_value);
+    verify_body_hash(digest_header.as_ref(), &body.unwrap_or_default())?;
 
-    let mut vec = Vec::<(_, _)>::with_capacity(request.headers().len());
-    request.headers().iter().for_each(|(k, v)| {
-        let k = reqwest::header::HeaderName::from_str(k.as_str()).expect("Failed to parse header");
-        let v = reqwest::header::HeaderValue::from_str(v.to_str().unwrap_or_default())
-            .expect("Failed to parse header");
-        vec.push((k, v));
-    });
-    let headers = vec.iter().map(|(k, v)| (k, v)).collect::<Vec<(_, _)>>();
-
-    http_signatures::signing_actor(
-        headers,
-        &reqwest::Method::from_str(request.method().as_str())
-            .map_err(|err| Error::Other(err.to_string()))?,
-        &http::Uri::from_str(&request.uri().to_string())
-            .map_err(|err| Error::Other(err.to_string()))?,
-        data,
-    )
-    .await
+    let headers = http_compat::header_map(request.headers());
+    let method = http_compat::method(request.method());
+    let uri = http_compat::uri(request.uri());
+    http_signatures::signing_actor(&headers, &method, &uri, data).await
 }
diff --git a/src/fetch/mod.rs b/src/fetch/mod.rs
index a310a95..b8e9c84 100644
--- a/src/fetch/mod.rs
+++ b/src/fetch/mod.rs
@@ -114,7 +114,7 @@ async fn fetch_object_http_with_accept<T: Clone, Kind: DeserializeOwned>(
     let req = config
         .client
         .get(url.as_str())
-        .header("Accept", content_type.as_bytes())
+        .header("Accept", content_type)
         .timeout(config.request_timeout);
 
     let res = if let Some((actor_id, private_key_pem)) = config.signed_fetch_actor.as_deref() {
@@ -131,16 +131,12 @@ async fn fetch_object_http_with_accept<T: Clone, Kind: DeserializeOwned>(
         req.send().await?
     };
 
-    if res.status().as_u16() == StatusCode::GONE.as_u16() {
+    if res.status() == StatusCode::GONE {
         return Err(Error::ObjectDeleted(url.clone()));
     }
 
     let url = res.url().clone();
-    let content_type = res
-        .headers()
-        .get("Content-Type")
-        .cloned()
-        .and_then(|v| HeaderValue::from_maybe_shared(v).ok());
+    let content_type = res.headers().get("Content-Type").cloned();
     let text = res.bytes_limited().await?;
     let object_id = extract_id(&text).ok();
 
diff --git a/src/http_signatures.rs b/src/http_signatures.rs
index c63c816..ab3fe19 100644
--- a/src/http_signatures.rs
+++ b/src/http_signatures.rs
@@ -14,16 +14,12 @@ use crate::{
 };
 use base64::{engine::general_purpose::STANDARD as Base64, Engine};
 use bytes::Bytes;
-use http::{uri::PathAndQuery, Uri};
+use http::{header::HeaderName, uri::PathAndQuery, HeaderValue, Method, Uri};
 use http_signature_normalization_reqwest::{
     prelude::{Config, SignExt},
     DefaultSpawner,
 };
-use reqwest::{
-    header::{HeaderName, HeaderValue},
-    Method,
-    Request,
-};
+use reqwest::Request;
 use reqwest_middleware::RequestBuilder;
 use rsa::{
     pkcs8::{DecodePublicKey, EncodePrivateKey, EncodePublicKey, LineEnding},
@@ -302,7 +298,7 @@ pub mod test {
         // use hardcoded date in order to test against hardcoded signature
         headers.insert(
             "date",
-            reqwest::header::HeaderValue::from_str("Tue, 28 Mar 2023 21:03:44 GMT").unwrap(),
+            HeaderValue::from_str("Tue, 28 Mar 2023 21:03:44 GMT").unwrap(),
         );
 
         let request_builder = ClientWithMiddleware::from(Client::new())